potiuk opened a new pull request, #72660:
URL: https://github.com/apache/airflow/pull/72660
…listing (#72640)
* Prevent Dag-existence disclosure on partitioned dag runs listing
The empty-results branch of the /ui/partitioned_dag_runs listing raised 404
when a Dag did not exist, but returned 200-empty when a Dag existed but was
outside the caller's permitted set (the readable-dags row filter had already
dropped its rows). A caller could therefore probe by dag_id and learn which
identifiers exist beyond what they are allowed to read.
Scope the existence probe to readable Dags so the two cases collapse to the
same 404, matching the "so their existence does not leak either" idiom used by
PermittedEventLogFilter / PermittedAssetEventFilter. Behavior is unchanged for
callers with full Dag access.
* Simplify existence check and strengthen leak-regression test
readable_dag_ids already comes from DagModel in both in-tree auth managers,
so membership in the set proves existence — the extra DagModel round-trip and
IN list is only useful for the admin path, where no filter is active.
Add an AssetPartitionDagRun for the unreadable Dag in the regression test so
the readable-dags row filter is what drops the rows, matching the scenario the
docstring describes.
* Declare 404 response on the partitioned dag runs listing
The listing raises HTTPException(404) when a dag_id filter targets a Dag the
caller cannot see, but the route did not declare 404 in its OpenAPI responses.
Clients generated from the spec therefore treated 404 as an unexpected
transport error rather than a documented outcome, and the API docs page did not
surface it.
* Tighten comment on the existence-check branch (cherry picked from commit
5c40e732444ed67c2b3f76c699aace93d520c6a6)
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
