justinpakzad commented on PR #70103: URL: https://github.com/apache/airflow/pull/70103#issuecomment-5576435090
> LGTM — all four points from my last pass are addressed: the deadline now derives from `ti.start_date`, `TERMINAL_STATUSES` / `NON_TERMINAL_STATUSES` keep their original names and stay importable from the operator module, both timeout paths log container output before dropping and respect `drop_on_completion`, and the statuses moved out of the SQL hook module into `utils/snowpark_containers.py`. CI is green and every thread is resolved. Four smaller observations inline, none blocking. Appreciate the second round of review. All good callouts and they've been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
