dheerenmohta commented on PR #72484: URL: https://github.com/apache/airflow/pull/72484#issuecomment-5579807204
Thanks for the detailed follow-up — addressed all three in 8a5420e: - **`test_connection_command.py:153`** — corrected the comment. It now names the module-level `clear_connections` fixture generically rather than pointing at the wrong `clear_db_connections`/`create_default_connections` call chain. - **`test_connection_command.py:174` / `test_variable_command.py:346`** — both now pin `[secrets] backend` and `[workers] secrets_backend` to `""` via `conf_vars`, matching the pattern already used in `TestGetHiddenEntriesWarning`. Applied the same fix to `test_utils.py::test_returns_none_when_nothing_is_hidden` / `test_warns_about_env_var_defined_entries`, which had the same gap one level down. - **`cli/utils.py:123`** — lifted the `(section, key)` pairs into a new `SECRETS_BACKEND_CONFIG_KEYS` constant in `shared/configuration/src/airflow_shared/configuration/parser.py`, and pointed `_get_custom_secret_backend()` at the same constant. Both now read from one place, so a future third source only needs to be added once. All 120 tests in the three affected files pass, plus the shared-parser and airflow-core configuration secret tests (unaffected, confirming the constant refactor didn't change `_get_custom_secret_backend()`'s behavior). --- Drafted-by: Claude Code (Sonnet 5) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
