realtimetodie commented on PR #72364: URL: https://github.com/apache/airflow/pull/72364#issuecomment-5580717477
@potiuk I think this change is generally badly designed and implemented at the wrong layer. `build_dag_metric_tags()` is shared by **multiple metric backends**, but #72364 applies StatsD-specific normalization there. That means the same normalization also affects OpenTelemetry metrics, even though OpenTelemetry attributes do not have the same character restrictions. This is also lossy. A tag such as env:pro d becomes env=pro_d, and non-ASCII characters are replaced as well. Once that happens, the original value cannot be recovered by the OpenTelemetry exporter. The StatsD problem is real, but the normalization should happen in the StatsD/InfluxDB-specific path, not in the shared DAG tag representation used by **every other** metrics backend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
