rjgoyln commented on PR #72083: URL: https://github.com/apache/airflow/pull/72083#issuecomment-5582229712
LGTM overall! The refactor looks behaviour-preserving. One concern: the new test would also pass on main, so it cannot fail when reverting the change. Could we either remove it or adjust it to specifically cover the replace() behaviour? One minor point: please consider adding a short comment explaining why the helper is outside __init__. Just my thoughts — feel free to resolve if you think otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
