dabla opened a new pull request, #72688:
URL: https://github.com/apache/airflow/pull/72688
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Invalidate the cached Microsoft Graph `RequestAdapter` when a request fails
with `401 Unauthorized`.
`KiotaRequestAdapterHook` caches a `RequestAdapter` per `conn_id` and only
rebuilds it when the underlying HTTP client or credential session is detected
as closed. If the Graph API starts returning `401` (e.g. an expired/revoked
token, tenant reconfiguration, or a token the credential wrongly believes is
still valid), the same broken adapter kept being reused and every subsequent
request failed due to an ExpiredToken error until the process was restarted.
`DefaultResponseHandler.handle_response_async` now raises `PermissionError`
for HTTP `401` responses instead of `AirflowBadRequest`.
`KiotaRequestAdapterHook.send_request` already caught `RuntimeError` and
`ValueError` to evict the cached adapter on failure; it now also catches
`PermissionError`, so a `401` evicts the stale adapter and the next request
rebuilds it (and re-authenticates) from scratch.
`PermissionError` was chosen over a new dedicated `AirflowUnauthorized`
exception class to keep the change minimal and avoid introducing a new public
exception type for this provider.
Added unit tests covering:
* `DefaultResponseHandler.handle_response_async` raises `PermissionError`
for a `401`
response.
* `KiotaRequestAdapterHook.send_request` evicts the cached request adapter
and re-raises
when the underlying call raises `PermissionError` (in addition to the
existing
`RuntimeError` coverage).
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Claude Sonnet 5
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
