pierrejeambrun commented on code in PR #72460:
URL: https://github.com/apache/airflow/pull/72460#discussion_r3959740779
##########
airflow-core/src/airflow/ui/src/pages/AssetsList/AssetsList.tsx:
##########
@@ -147,6 +148,8 @@ export const AssetsList = () => {
const { filterConfigs, handleFiltersChange, initialValues } =
useFiltersHandler(assetsFilterKeys);
+ const hasEventsParam = searchParams.get(SearchParamsKeys.HAS_EVENTS);
+ const hasEvents = hasEventsParam === "true" ? true : hasEventsParam ===
"false" ? false : undefined;
Review Comment:
Nit to be consistent with other params like this "PAUSED, FAVORITE, etc..."
```ts
let hasEvents = undefined;
if (hasEventsParam === "true") {
hasEvents = true;
} else if (hasEventsParam === "false") {
hasEvents = false;
}
```
##########
airflow-core/newsfragments/72460.feature.rst:
##########
Review Comment:
Can you remove it.
We need to change our agents.md. "user facing" but critical, basically we
only use newsfragment for 'significant' ones, not for general
feature/bugfix/improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
