kaxil commented on PR #71437: URL: https://github.com/apache/airflow/pull/71437#issuecomment-5593864288
Two things the rebase will surface, since the branch predates some churn in this area. `get_ui_field_behaviour()` now advertises `embed_model` in the `extra` placeholder, but #72087 made `provider.yaml`'s `ui-field-behaviour.placeholders` mirror the hook. So `placeholders.extra` for the `pydanticai` type, and its `get_provider_info.py` copy, needs the same update or the two disagree again. The per-vendor connection pages added in #71774 (`pydantic_ai_azure.rst`, `pydantic_ai_bedrock.rst`, `pydantic_ai_vertex.rst`) enumerate every conn-field, down to `Force Vertex AI Mode` and `Custom Endpoint URL`. This PR adds `embed_model` to those three connection types but documents it only in `pydantic_ai.rst`, so each of the three wants an Embedding Model entry. Separately, I checked the examples and the dependency floor and both are fine. All four `embed_model` descriptions resolve against pydantic-ai 2.0 (`openai:text-embedding-3-small`, `azure:text-embedding-3-small` gives an `OpenAIEmbeddingModel`, `bedrock:amazon.titan-embed-text-v2:0`, `google-cloud:text-embedding-005`), and `Embedder` plus `infer_embedding_model` are both present at the declared `pydantic-ai-slim>=2.0.0` floor. #72012 moved the Vertex examples to the `google-cloud:` prefix, so your embed example already matches where main went. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
