CaptainAni187 commented on PR #72703: URL: https://github.com/apache/airflow/pull/72703#issuecomment-5594980130
Thanks @rjgoyln — both applied in 52db5de. You were right that the ternary was doing the same `isinstance` dispatch the next branch performs; folding the sign decision into the two arms reads better and does one type check instead of two. Good catch on the docstring too. The sub-second case was only explained in the PR description, which isn't much help to someone reading the function. It now says a magnitude below one second stays `<1s` without a sign. `shared/timezones`: 31 passed. `ruff check` and `ruff format` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
