This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 91657fe9fde Remove unused FAB app-init helpers that could never run
(#72610)
91657fe9fde is described below
commit 91657fe9fde16aa17701238944f6e260dec76edb
Author: PoAn Yang <[email protected]>
AuthorDate: Wed Sep 9 22:15:31 2026 +0900
Remove unused FAB app-init helpers that could never run (#72610)
---
providers/fab/src/airflow/providers/fab/www/app.py | 12 ------------
.../airflow/providers/fab/www/extensions/init_views.py | 15 ---------------
providers/fab/tests/unit/fab/auth_manager/conftest.py | 1 -
providers/fab/tests/unit/fab/decorators.py | 4 ----
providers/fab/tests/unit/fab/www/views/conftest.py | 1 -
5 files changed, 33 deletions(-)
diff --git a/providers/fab/src/airflow/providers/fab/www/app.py
b/providers/fab/src/airflow/providers/fab/www/app.py
index 28bdae34189..f28cd29c0db 100644
--- a/providers/fab/src/airflow/providers/fab/www/app.py
+++ b/providers/fab/src/airflow/providers/fab/www/app.py
@@ -18,7 +18,6 @@
from __future__ import annotations
from datetime import timedelta
-from functools import cache
from os.path import isabs
from flask import Flask
@@ -131,14 +130,3 @@ def create_app(enable_plugins: bool):
init_jinja_globals(flask_app, enable_plugins=enable_plugins)
init_wsgi_middleware(flask_app)
return flask_app
-
-
-@cache
-def cached_app():
- """Return cached instance of Airflow WWW app."""
- return create_app()
-
-
-def purge_cached_app():
- """Remove the cached version of the app in global state."""
- cached_app.cache_clear()
diff --git
a/providers/fab/src/airflow/providers/fab/www/extensions/init_views.py
b/providers/fab/src/airflow/providers/fab/www/extensions/init_views.py
index f83825f81c0..1d6443f118b 100644
--- a/providers/fab/src/airflow/providers/fab/www/extensions/init_views.py
+++ b/providers/fab/src/airflow/providers/fab/www/extensions/init_views.py
@@ -23,21 +23,6 @@ from airflow.providers.fab.version_compat import
AIRFLOW_V_3_1_PLUS, AIRFLOW_V_3
log = logging.getLogger(__name__)
-def init_appbuilder_views(app):
- """Initialize Web UI views."""
- from airflow.models import import_all_models
- from airflow.providers.fab.www import views
-
- import_all_models()
-
- appbuilder = app.appbuilder
-
- # Remove the session from scoped_session registry to avoid
- # reusing a session with a disconnected connection
- appbuilder.session.remove()
- appbuilder.add_view_no_menu(views.FabIndexView())
-
-
def init_plugins(app):
"""Integrate Flask and FAB with plugins."""
from airflow import plugins_manager
diff --git a/providers/fab/tests/unit/fab/auth_manager/conftest.py
b/providers/fab/tests/unit/fab/auth_manager/conftest.py
index f8a13ec0588..9f05289f05c 100644
--- a/providers/fab/tests/unit/fab/auth_manager/conftest.py
+++ b/providers/fab/tests/unit/fab/auth_manager/conftest.py
@@ -35,7 +35,6 @@ def minimal_app_for_auth_api():
"init_appbuilder",
"init_api_auth",
"init_airflow_session_interface",
- "init_appbuilder_views",
]
)
def factory():
diff --git a/providers/fab/tests/unit/fab/decorators.py
b/providers/fab/tests/unit/fab/decorators.py
index 64d9a762401..dd007751f81 100644
--- a/providers/fab/tests/unit/fab/decorators.py
+++ b/providers/fab/tests/unit/fab/decorators.py
@@ -19,8 +19,6 @@ from __future__ import annotations
import functools
from unittest.mock import patch
-from airflow.providers.fab.www.app import purge_cached_app
-
def dont_initialize_flask_app_submodules(_func=None, *, skip_all_except=None):
if not skip_all_except:
@@ -45,10 +43,8 @@ def dont_initialize_flask_app_submodules(_func=None, *,
skip_all_except=None):
if method not in skip_all_except:
patcher = patch(f"airflow.providers.fab.www.app.{method}",
no_op)
patcher.start()
- purge_cached_app()
result = f(*args, **kwargs)
patch.stopall()
- purge_cached_app()
return result
diff --git a/providers/fab/tests/unit/fab/www/views/conftest.py
b/providers/fab/tests/unit/fab/www/views/conftest.py
index 96c423947e1..7b289966c7d 100644
--- a/providers/fab/tests/unit/fab/www/views/conftest.py
+++ b/providers/fab/tests/unit/fab/www/views/conftest.py
@@ -54,7 +54,6 @@ def app(examples_dag_bag):
@dont_initialize_flask_app_submodules(
skip_all_except=[
"init_appbuilder",
- "init_appbuilder_views",
"init_jinja_globals",
"init_plugins",
"init_airflow_session_interface",
