jabrailkhalil opened a new pull request, #72847: URL: https://github.com/apache/airflow/pull/72847
<!-- Thank you for contributing! Please make sure that your commit messages mention the issue number (Fixes #72269). --> ## Summary `providers/cloudant/src/airflow/providers/cloudant/cloudant_fake.py` is dead code: it defined two no-op stand-ins (`CloudantV1`, `CouchDbSessionAuthenticator`) for the conditional import fallback that was needed while `ibmcloudant` was excluded on Python 3.9. PR #52072 dropped Python 3.9 support, removed the version guard and the `excluded-python-versions` block, and the hook now imports both classes directly from `ibmcloudant`. The stub module was left behind. A repository-wide search finds no import of `airflow.providers.cloudant.cloudant_fake` in any source, test, or configuration file; its only remaining reference was its own `OVERLOOKED_TESTS` entry. ## Changes - Delete `providers/cloudant/src/airflow/providers/cloudant/cloudant_fake.py`. - Remove the `providers/cloudant/tests/unit/cloudant/test_cloudant_fake.py` entry from `OVERLOOKED_TESTS` in `airflow-core/tests/unit/always/test_project_structure.py`. ## Verification - `grep -r cloudant_fake` across the repository: only the allowlist entry existed (now removed). - `pytest airflow-core/tests/unit/always/test_project_structure.py -k TestProjectStructure --confcutdir=...` : 3 passed, including `test_providers_modules_should_have_tests` (the allowlist check). - The full `test_project_structure.py` run has 1 pre-existing failure unrelated to this change: `TestDockerProviderProjectStructure::test_missing_examples` raises `UnicodeDecodeError` on Windows (python reads a provider file with the default `cp1251` codec; no encoding is specified in the test). It also fails on a clean checkout on this platform. No newsfragment is needed: no user-visible behavior changes (internal dead module removed, test-allowlist cleanup). Fixes #72269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
