uranusjr commented on code in PR #65618:
URL: https://github.com/apache/airflow/pull/65618#discussion_r3975757272
##########
providers/common/sql/src/airflow/providers/common/sql/triggers/sql.pyi:
##########
@@ -29,16 +29,25 @@
#
"""Definition of the public interface for
airflow.providers.common.sql.triggers.sql."""
-from collections.abc import AsyncIterator
+from collections.abc import AsyncIterator, Iterable, Mapping
from typing import Any
from airflow.providers.common.sql.hooks.sql import DbApiHook as DbApiHook
from airflow.triggers.base import BaseTrigger as BaseTrigger, TriggerEvent as
TriggerEvent
class SQLExecuteQueryTrigger(BaseTrigger):
def __init__(
- self, sql: str | list[str], conn_id: str, hook_params: dict | None =
None, **kwargs
+ self,
+ sql: str | Iterable[str],
+ conn_id: str,
+ autocommit: bool,
+ split_statements: bool,
+ return_last: bool,
+ parameters: Iterable[Any] | Mapping[str, Any] | None = None,
+ fetch_results: bool = False,
+ read_only: bool = False,
+ hook_params: dict | None = None,
Review Comment:
This differs from the actual implementation. If you want these to always be
keyword-only (i.e. argument ordering does not matter), make these keyword-only
with `*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
