steveahnahn commented on code in PR #72668:
URL: https://github.com/apache/airflow/pull/72668#discussion_r3981531973
##########
airflow-core/src/airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -432,9 +453,12 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
new_state = TaskInstanceState.UPSTREAM_FAILED
elif skipped:
new_state = TaskInstanceState.SKIPPED
- elif removed and success and ti.map_index > -1:
- if ti.map_index >= success:
- new_state = TaskInstanceState.REMOVED
+ elif removed and ti.map_index > -1:
+ # All counted (live) instances are successes here, so
with a strict 1:1
+ # mapping the success count is the ti's own
post-shrink expansion length.
+ if upstream_done and
_covers_expansion_one_to_one(task, task.upstream_task_ids):
+ if ti.map_index >= success:
+ new_state = TaskInstanceState.REMOVED
Review Comment:
Kept and success, so the all-removed case matches main. Your producer/work
reproduction is now a test; it fails on the previous revision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
