pierrejeambrun commented on PR #72811: URL: https://github.com/apache/airflow/pull/72811#issuecomment-5623970801
> On the new docstring line, I was wrong last round: I said asserting logical_date would cover the load_only half, and it does not, so "eager-loaded" claims more than the test checks. capture_orm_selects keeps only statements matching \bFROM task_instance\b ([asserts.py#L202](https://github.com/apache/airflow/blob/a9f6c898f01dc1e5e1dc18172f5bc65097957a71/devel-common/src/tests_common/test_utils/asserts.py#L202)). If logical_date were deferred rather than eager-loaded, it would arrive through a separate SELECT dag_run.logical_date ... FROM dag_run WHERE dag_run.id = ?, which that filter drops, so the loop never inspects it and data["logical_date"] still comes back correct. The assert proves the value is right, not that it came from the join. A query count around the request would pin the eager-load claim; short of that, the docstring is the thing to soften. Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
