keith991001 opened a new pull request, #72915:
URL: https://github.com/apache/airflow/pull/72915

   Adds the missing test module for 
`airflow.providers.common.messaging.providers.base_provider` and removes its 
entry from `OVERLOOKED_TESTS` in `test_project_structure.py`, per the checklist 
in the meta issue.
   
   The tests cover the concrete surface of `BaseMessageQueueProvider`: 
`scheme_matches` across matching / non-matching / empty / None schemes, the 
base-class `scheme = None` default matching nothing, and markers asserting 
which contract methods are declared abstract (and that `scheme_matches` is not).
   
   While writing these I noticed the declared abstract contract is out of sync 
with the in-tree providers (three of them implement only `trigger_class`, which 
currently goes unenforced because the base class does not inherit `abc.ABC`) — 
that needs a maintainer decision on direction, so it is filed separately rather 
than "fixed" here; the tests deliberately avoid enshrining the unenforced 
behavior.
   
   10 tests, all passing locally via `uv run --project 
providers/common/messaging pytest ...`; the 
`test_providers_modules_should_have_tests` guard passes with the entry removed.
   
   related: #35442
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5)
   
   Generated-by: Claude Code (Fable 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to