ShousenZHANG commented on issue #35442: URL: https://github.com/apache/airflow/issues/35442#issuecomment-5636430334
Following up on my earlier comment: I have gone through the rest of the `providers/google/tests/unit/google/cloud/links/` entries in the list. Posting the full set here so nobody duplicates the work. Each PR adds one test module and removes only its own `OVERLOOKED_TESTS` line. | module | PR | | --- | --- | | `test_bigquery_dts.py` | #72949 | | `test_dataprep.py` | #72955 | | `test_datastore.py` | #72956 | | `test_bigtable.py` | #72960 | | `test_cloud_build.py` | #72961 | | `test_cloud_functions.py` | #72962 | | `test_cloud_memorystore.py` | #72963 | | `test_cloud_sql.py` | #72964 | | `test_compute.py` | #72965 | | `test_data_loss_prevention.py` | #72966 | | `test_dataflow.py` | #72967 | | `test_dataform.py` | #72968 | | `test_datafusion.py` | #72969 | | `test_dataproc.py` | #72970 | | `test_kubernetes_engine.py` | #72971 | | `test_pubsub.py` | #72972 | | `test_spanner.py` | #72973 | | `test_stackdriver.py` | #72974 | | `test_translate.py` | #72975 | | `test_workflows.py` | #72976 | `test_cloud_tasks.py` is deliberately left out — #72846 already covers it. They all follow the three checks the existing `test_bigquery.py` (#68066) in the same directory uses: the class attributes, the `persist` XCom payload, and the `_format_link` output. A few modules needed extra cases and those are called out in the individual PRs — `KubernetesEngineClusterLink` and the two `output_config` translate links override `persist`, and Cloud Functions, Compute, DLP, Dataproc, Translate and the Data Fusion instance link build their constants on `BASE_LINK` so `_format_link` does not prefix the console base a second time. One thing worth flagging: because these all delete adjacent lines from the same `OVERLOOKED_TESTS` block, they will conflict with each other as they merge. I will rebase the remainder every time one lands. If you would rather review fewer PRs, say so and I will squash them into a handful of grouped ones instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
