kaxil commented on PR #72973: URL: https://github.com/apache/airflow/pull/72973#issuecomment-5636650154
Also, one PR per module is the wrong unit: twenty PRs for one logical change is twenty reviews and twenty CI runs, when it should have been a single PR. The tests add little on their own merits either, since `test_class_attributes` compares `format_str` against the same constant imported from the module under test, and `test_format_link` derives its expected value from the same `.format()` call the implementation makes, so a broken link string still passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
