Lee-W commented on code in PR #71478: URL: https://github.com/apache/airflow/pull/71478#discussion_r3988243598
########## registry/src/_data/providerExternalServices.js: ########## @@ -0,0 +1,43 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// Shared by the pagefind index builder and the `externalServices` Eleventy +// filter (used for the /providers/ filter box), so the two search paths read +// the same field off the same shape and can't drift apart. Review Comment: Yes, but opt-in per category rather than for all of them. `collectSearchableValues()` now takes `{ includeExternalServices }` and `exploreCategories.js` sets it only on `ai-ml`; the default is off, so a new category has to opt in. Feeding every category would misfile providers. `cloud`'s keywords (`amazon`, `google`, `microsoft-azure`, …) are provider distribution ids — an identity claim — so Common AI's bare `Google` service name would land it in `cloud`. `ai-ml` is the only category keyed on integration names (`langchain`, `llamaindex`, `pydantic ai`), which is the same axis `external-services` describes. The two consumers now share `categoryMatchesProvider()` so the options can't drift between them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
