xvega commented on PR #71349:
URL: https://github.com/apache/airflow/pull/71349#issuecomment-5662298643

   > Overall, the Google provider parts LGTM. However, it now relies on 
`_cached_kube_client` and `close()`, which are added to `AsyncKubernetesHook` 
in this PR. Without marking this cross-provider dependency, the Google provider 
could still be installed with an older Kubernetes provider and fail with an 
`AttributeError` on the first GKE trigger poll.
   > 
   > Should we add `# use next version` at here?
   > 
   > 
https://github.com/apache/airflow/blob/b4d012936c5abe5f6b9b68eff085f98f30018370/providers/google/pyproject.toml#L166
   
   I added # use next version 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to