[
https://issues.apache.org/jira/browse/AIRFLOW-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013017#comment-17013017
]
ASF GitHub Bot commented on AIRFLOW-6528:
-----------------------------------------
potiuk commented on pull request #7124: [AIRFLOW-6528] disable flake8 W503 line
break before binary operator
URL: https://github.com/apache/airflow/pull/7124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> disable W503 flake8 check (line break before binary operator)
> -------------------------------------------------------------
>
> Key: AIRFLOW-6528
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6528
> Project: Apache Airflow
> Issue Type: Bug
> Components: pre-commit
> Affects Versions: 1.10.7
> Reporter: Daniel Standish
> Priority: Trivial
>
> Flake8's W503 rule says there should be no line break before binary operator.
> This rule is incompatible with black formatter, and is also in my opinion bad
> style.
> Status quo example with W503 check enabled:
> {code}
> @property
> def sqlalchemy_scheme(self):
> """
> Database provided in init if exists; otherwise, ``schema`` from
> ``Connection`` object.
> """
> return (
> self._sqlalchemy_scheme or
> self.connection_extra_lower.get('sqlalchemy_scheme') or
> self.DEFAULT_SQLALCHEMY_SCHEME
> )
> {code}
> as required by black (W503 disabled)
> {code}
> @property
> def sqlalchemy_scheme(self):
> """
> Database provided in init if exists; otherwise, ``schema`` from
> ``Connection`` object.
> """
> return (
> self._sqlalchemy_scheme
> or self.connection_extra_lower.get('sqlalchemy_scheme')
> or self.DEFAULT_SQLALCHEMY_SCHEME
> )
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
