kaxil commented on code in PR #72164: URL: https://github.com/apache/airflow/pull/72164#discussion_r4009428819
########## airflow-core/newsfragments/72164.significant.rst: ########## @@ -0,0 +1,23 @@ +``[core] execute_tasks_new_python_interpreter`` now applies to Airflow 3 task processes + +On Airflow 3 the option had no effect on task execution (only the Edge worker read it). When set to Review Comment: ```suggestion On Airflow >=3.0,<=3.3 the option had no effect on task execution (only the Edge worker read it). When set to ``` ########## airflow-core/newsfragments/72164.significant.rst: ########## @@ -0,0 +1,23 @@ +``[core] execute_tasks_new_python_interpreter`` now applies to Airflow 3 task processes + +On Airflow 3 the option had no effect on task execution (only the Edge worker read it). When set to +``True``, the task supervisor now ``exec``\ s a fresh interpreter right after forking the task process, +which prevents the fork from inheriting a lock held by a supervisor thread (a permanent hang at the +task's first TLS call). Deployments that kept the option ``True`` from Airflow 2 get this behaviour, +and its per-task interpreter start-up cost, on upgrade without further action; set it to ``False`` to +keep bare fork. The task process reads the global value, so a team-scoped Edge setting alone does not +turn it on. Edge workers with the option ``True`` already start a fresh interpreter for the supervisor Review Comment: Is this for the Edge provider? ########## airflow-core/newsfragments/72164.significant.rst: ########## @@ -0,0 +1,23 @@ +``[core] execute_tasks_new_python_interpreter`` now applies to Airflow 3 task processes + +On Airflow 3 the option had no effect on task execution (only the Edge worker read it). When set to +``True``, the task supervisor now ``exec``\ s a fresh interpreter right after forking the task process, +which prevents the fork from inheriting a lock held by a supervisor thread (a permanent hang at the +task's first TLS call). Deployments that kept the option ``True`` from Airflow 2 get this behaviour, +and its per-task interpreter start-up cost, on upgrade without further action; set it to ``False`` to +keep bare fork. The task process reads the global value, so a team-scoped Edge setting alone does not Review Comment: ```suggestion keep bare fork. The task process reads the global value, so a team-scoped setting alone does not ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
