o-nikolas commented on code in PR #72892:
URL: https://github.com/apache/airflow/pull/72892#discussion_r4020677274


##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/azure_blob_to_s3.py:
##########
@@ -116,6 +116,29 @@ def __init__(
         self.wasb_extra_args = wasb_extra_args or {}
         self.s3_extra_args = s3_extra_args or {}
 
+    @staticmethod
+    def _strip_overlapping_folder_markers(keys: list[str]) -> tuple[list[str], 
list[str]]:

Review Comment:
   Can you reuse the same code we have for the other GCS usecase you mentioned? 



##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/azure_blob_to_s3.py:
##########


Review Comment:
   Can you sort these as well so that both replace True and false paths have 
equivalent order 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to