pierrejeambrun opened a new pull request, #73239:
URL: https://github.com/apache/airflow/pull/73239

   Backport of #72795 to `v3-3-test`.
   
   **Not a clean cherry-pick.** `v3-3-test`'s `parameters.py` has a smaller set 
of query-parameter definitions than `main` (several PRs that added `Query*` 
params were not backported — e.g. regex, teams, JSON-KV, asset-event, and 
scheduling-state filters). A straight cherry-pick of #72795 (which deletes 
`main`'s `parameters.py` and adds the package built from it) would conflict 
wholesale, so the split was **re-created on v3-3-test's actual file using the 
same methodology** as the original PR:
   
   - **Pure move:** every one of the 138 top-level definitions is 
byte-identical to the original `parameters.py` (verified by AST source-segment 
comparison); all 56 non-license comments are preserved. No implementation 
changed.
   - **Same module layout:** machinery (`base`, `search`, `filter`, `sort`, 
`range`) + per-domain aliases (`dag`, `dag_run`, `task_instance`, `xcom`, 
`asset`, `misc`), with the name→module mapping taken from the merged #72795 
package.
   - **`__init__` re-exports only the names imported by non-test code** (109) — 
internal helpers that nothing outside the package consumes are not re-exported.
   - **Tests import package-private helpers from their submodules** (7 names: 
`NullableDatetimeRangeFilter`, `_AssetDependencyFilter`, 
`_ConsumingAssetFilter`, `_OwnersFilter`, `_PrefixPatternParam`, 
`_TaskDisplayNamePrefixPatternParam`, `_escape_like_pattern`) rather than 
through the package root.
   - Intra-package private imports resolved and placed in the first-party 
import group.
   
   The only difference from #72795 (beyond the smaller def set): v3-3-test has 
no `regex_param_factory`, so there is no 
`TestRegexParamFactory`/`apply_regex_query_timeout` `mock.patch` to update.
   
   Verified: byte-identical move, ruff + `mypy-airflow-core` clean, `__init__` 
exports reconcile exactly with the set imported across the repo (zero broken 
imports in 37 consumer files), package + consumer modules import cleanly, and 
the parameter/cursor test suites pass (71). Route-test suites additionally run 
in CI.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to