jroachgolf84 commented on code in PR #73215:
URL: https://github.com/apache/airflow/pull/73215#discussion_r4028655392
##########
providers/amazon/tests/unit/amazon/aws/sensors/test_opensearch_serverless.py:
##########
@@ -102,3 +102,22 @@ def test_poke_failure_states(self, mock_conn, state):
sensor =
OpenSearchServerlessCollectionActiveSensor(**self.default_op_kwargs,
aws_conn_id=None)
with pytest.raises(AirflowException, match=sensor.FAILURE_MESSAGE):
sensor.poke({})
Review Comment:
```suggestion
sensor.poke({})
```
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/opensearch_serverless.py:
##########
@@ -46,14 +46,16 @@ def __init__(
waiter_delay: int = 60,
waiter_max_attempts: int = 20,
aws_conn_id: str | None = None,
+ region_name: str | None = None,
+ verify: bool | str | None = None,
+ botocore_config: dict | None = None,
Review Comment:
+1
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/opensearch_serverless.py:
##########
@@ -46,14 +46,16 @@ def __init__(
waiter_delay: int = 60,
waiter_max_attempts: int = 20,
aws_conn_id: str | None = None,
+ region_name: str | None = None,
+ verify: bool | str | None = None,
+ botocore_config: dict | None = None,
) -> None:
if not exactly_one(collection_id is None, collection_name is None):
raise AttributeError("Either collection_ids or collection_names
must be provided, not both.")
super().__init__(
serialized_fields={"collection_id": collection_id,
"collection_name": collection_name},
waiter_name="collection_available",
- # waiter_args is a dict[str, Any], allow a possible list of None
(it is caught above)
Review Comment:
+1
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/opensearch_serverless.py:
##########
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
