kaxil commented on PR #73173: URL: https://github.com/apache/airflow/pull/73173#issuecomment-5706379488
> Two PRs were already working on this, both are tagged "closes: #69030", and I've been working with those authors. #66350 has been open since 4 May and has been through several rounds of review. #71732 came in August and was cherry-picked into #66350 to avoid the two conflicting. Same three tables, same cause, same fix. > > Your `--exclude-dag-ids` handling is a real catch, and broader than anything either PR had. But that's multiple months of working with a new contributor sidestepped when a search for those table names would have turned up both of those PRs. > > Please don't close #66350. It also re-applies `skip_if_referenced` on the DELETE which fixes a race condition where a `task_instance` which points at a `dag_version` might appear between the archive INSERT and the DELETE, and it has a guard asserting every `dag_id_column_name` in `config_dict` is a real column of its table, to catch this class of config drift directly rather than through the filter path. Neither of those is in #73173, so I've asked @jakubmatyszewski to rescope his PR down to those two. Commented on that PR too, thanks Dennis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
