henry3260 commented on code in PR #73008:
URL: https://github.com/apache/airflow/pull/73008#discussion_r4034306764
##########
airflow-core/src/airflow/api_fastapi/core_api/services/ui/dependencies.py:
##########
Review Comment:
> I think this path can still fail before the unreadable/stale asset node
gets pruned. `_asset_node_id_and_label()` can produce `asset:None` for a
concrete asset leaf whose id has not been re-enriched yet, but here we only
check `startswith("asset:")` before calling `int(...)`.
>
> In that case this becomes `int("None")`, so the data dependencies graph
would return 500 instead of hiding the stale asset node. Could this guard use
`_is_readable_asset_node()` as well, or otherwise only add numeric readable
asset ids to `next_frontier`?
good catch applied!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
