namanjain24-sudo commented on code in PR #73104: URL: https://github.com/apache/airflow/pull/73104#discussion_r4040085954
########## providers/fab/docs/changelog.rst: ########## @@ -20,6 +20,13 @@ Changelog --------- +.. note:: Review Comment: Removed in 5bea57fd17. I had added it on an earlier review suggestion, but you are right: the provider changelog is prepared at release time and reserved for breaking changes, and this is a bug fix. The behaviour it described (the role and permission sync no longer runs on every users/roles API call, so a role created through the API gets `can_read` on `Website` only at the next startup sync or `airflow sync-perm`) stays in the PR description. I also rebased on main and re-ran everything there: FAB `api_fastapi` 155 passed, full FAB unit suite 695 passed / 4 skipped, and the two new tests still fail against the old routes with `Expected 'init_app' to not have been called. Called 2 times.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
