karenbraganz commented on PR #68048:
URL: https://github.com/apache/airflow/pull/68048#issuecomment-5721455787
> The original issue described a second problem
>
> > index 0 is not guaranteed to be the driver container in a
multi-container pod.
>
> This is reachable whenever `driver_container` is None and I think the PR
does not address this? It’s fine to be fixed separately, but in that case the
PR can’t close the issue outright.
I had initially decided to leave that part of the code as is because it only
acts as a fallback when the driver container cannot be identified. However, now
I am thinking it might be more accurate to just report the pod failure without
the exact container status even in case of the fallback. Something like this:
```
if phase == "Succeeded":
terminal_phase = phase
break
if phase == "Failed" and not container_completed:
raise RuntimeError(f"Spark application {app_id} failed (phase=Failed)")
```
Or we could print the statuses of all containers in the pod without assuming
any specific one is the driver. @uranusjr what do you think?
I can create a separate PR for this. I have edited this PR description so
that it dos not say that the issue is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
