amoghrajesh commented on code in PR #73027:
URL: https://github.com/apache/airflow/pull/73027#discussion_r4043887089
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1931,9 +1932,17 @@ def _finalize_task_failure(
if retry_reason is not None:
retry_kwargs["retry_reason"] = retry_reason[:500]
return RetryTask(**retry_kwargs), TaskInstanceState.UP_FOR_RETRY
+ if retry_reason is not None and ti._ti_context_from_server is not None:
+ # max_tries is the retry count, not the attempt count -- total
attempts is max_tries + 1.
+ total_attempts = ti._ti_context_from_server.max_tries + 1
+ suffix = f"; retries exhausted ({ti.try_number} of {total_attempts})"
Review Comment:
Fixed. If a task has no retries set up, we no longer say "exhausted" - that
word doesn't make sense there. Also added a log line so this decision now shows
up in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
