xBis7 commented on code in PR #73276:
URL: https://github.com/apache/airflow/pull/73276#discussion_r4050148647
##########
providers/apache/kafka/provider.yaml:
##########
@@ -202,6 +202,25 @@ config:
type: string
example: ~
default: "airflow.events"
+ version_deprecated: 2.1.0
Review Comment:
My initial assumption was that people will dump everything from the topic
and then use other tools (e.g. elastic search) to filter and find what they
need or do some sort of processing and visualization.
It depends on the individual needs and what's easier. Why deprecate the
original config and not keep it around?
If `topic` is configured then everything goes into 1 topic, otherwise if
`topic` is empty and the other 2 configs are provided, everything is split into
2 topics.
And from the perspective of consuming the messages in dags, 1 topic seems
simpler than 2.
I'm not against the changes, I'm just saying that it might make sense for
people to want 1 topic unless you have reasons that explain why 2 topics are
better than 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
