abhinav-phi commented on PR #73109:
URL: https://github.com/apache/airflow/pull/73109#issuecomment-5737843198
Thanks for the review! I've addressed both points:
**1. Review comment (accept either status):**
`EksDeleteClusterOperator.execute_complete` now accepts both `"deleted"` (what
`EksDeleteClusterTrigger` actually yields today) and `"success"`, so a future
transition to the usual event keeps working without breakage:
`if validated_event["status"] in ("deleted", "success"):`
**2. Failing checks:** the 2 failures (`Compat 2.11.1` and `Compat 3.0.6`,
from `logs_94436221977.zip`) were both the same test:
`TestEksDeleteClusterOperator::test_execute_complete_when_trigger_yields_deleted
- TypeError: argument of type 'LogCaptureFixture' is not iterable`
The `assert ... in caplog` structured-membership form only works on main
where `caplog` is overridden to `StructlogCapture`; on compat runs it's the
stock pytest `LogCaptureFixture`. Switched to `assert "Cluster deleted
successfully." in caplog.messages`, which exists on both fixtures (and matches
the prevailing style in this file, e.g. line 389), and parametrized the test
over `["deleted", "success"]` to cover the new condition. The log line itself
was fine — CI captured `INFO - Cluster deleted successfully.` — only the
assertion was incompatible.
`ruff check` and `ruff format --check` are clean on both files. Pushed as an
amend to the single commit; CI should re-run now.
Is there anything else you'd like changed?
---
Drafted-by: Muse Spark (muse-spark-1.3-contributor-free) (no human review
before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
