kaxil commented on PR #73370:
URL: https://github.com/apache/airflow/pull/73370#issuecomment-5749487786

   Two notes on the description:
   
   - "falling back to Application Default Credentials when neither is set": 
with `service_account_path=None` the binding builds a bare 
`GoogleCloudStorageBuilder` and never calls `from_env()`, so 
`GOOGLE_APPLICATION_CREDENTIALS` is not read. The fallback only finds the 
gcloud ADC file under `$HOME/.config/gcloud/` or the GCE/GKE metadata server. 
Either tighten the wording or honour the env var as the `key_path` fallback.
   - "docs updated to mention GCS alongside S3": 
`providers/common/sql/docs/operators.rst` still lists GCS under "not yet 
supported" in the Supported Storage Systems section (line 302 at this head).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to