ColtenOuO commented on code in PR #73381:
URL: https://github.com/apache/airflow/pull/73381#discussion_r4056920356
##########
providers/common/ai/src/airflow/providers/common/ai/toolsets/sql.py:
##########
@@ -171,9 +171,10 @@ class SQLToolset(AbstractToolset[Any]):
:param db_conn_id: Airflow connection ID for the database.
:param allowed_tables: Restrict the agent to a fixed set of tables.
``None``
- (default) exposes every table in ``schema``. Entries may be
schema-qualified
- (``"SCHEMA.TABLE"``) to span multiple schemas in one database --
common on
- warehouses such as Snowflake. ``list_tables`` introspects each
referenced
+ (default) exposes every table in ``schema``; an empty list raises
+ ``ValueError`` rather than silently exposing every table. Entries may
be
Review Comment:
Done -- the empty-list clause is now in the `allowed_tables` bullet on that
page too, phrased the same way as the docstring so the two stay in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
