amoghrajesh commented on code in PR #73030:
URL: https://github.com/apache/airflow/pull/73030#discussion_r4060541465
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Details.tsx:
##########
@@ -162,6 +172,12 @@ export const Details = () => {
</Flex>
</Table.Cell>
</Table.Row>
+ {tryInstance?.retry_reason === null || tryInstance?.retry_reason ===
undefined ? undefined : (
Review Comment:
Kept the banner on the latest try but stopped it sharing the row's label,
which is what made the two read as a duplicate on the default view and as an
unexplained disagreement elsewhere. It now titles itself with the try counts -
"Stopped on try 3 of 3", or "Retrying after try 2 of 3" - so it states which
attempt it describes and the row underneath stays scoped to the selected try.
That also fills a gap the page had regardless of this feature: the retry
limit was not shown anywhere, so "retries exhausted" in the reason text had
nothing to anchor to.
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Details.tsx:
##########
@@ -162,6 +172,12 @@ export const Details = () => {
</Flex>
</Table.Cell>
</Table.Row>
+ {tryInstance?.retry_reason === null || tryInstance?.retry_reason ===
undefined ? undefined : (
Review Comment:
Gated the banner on failed/up_for_retry, so a cleared task no longer shows a
reason describing the previous attempt.
Leaving the column itself alone here and doing it as a separate PR, because
the staleness predates both of these PRs and is wider than it first looks:
`clear_task_instances` leaves `retry_delay_override` behind too, and that one
is functional rather than cosmetic, `next_retry_datetime` reads it in
preference to the task's configured `retry_delay`, so a policy supplied delay
from an earlier run silently controls the timing of the next retry after a
clear, even if the policy has since changed or been removed. That seems worth
its own change and its own test against a function this heavily used, rather
than riding along in a UI PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
