kaxil commented on PR #72793: URL: https://github.com/apache/airflow/pull/72793#issuecomment-5760067037
Thanks for this. #68954 fixes the same issue with the same change in `_xcom_push` and was opened first, so I've merged that one and am closing this as a duplicate. Two pieces of your PR are not in #68954 and would be worth a small follow-up PR if you're up for it: 1. The same early return for `XCOM_SKIPMIXIN_KEY` in `_axcom_push`, so `axcom_push` matches the sync path. 2. The async-safe `_aset_xcom_in_db` / `_axcom_push_to_db` helpers you added, since the sync `_set_xcom_in_db` raises `DeadlockImminentError` when called from the event loop thread while an `asend` holds the lock. Your async test from this PR covers both nicely. Please reference #50491 and this PR in the follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
