MichalJaroslawKrzywanski-TomTom commented on issue #73425:
URL: https://github.com/apache/airflow/issues/73425#issuecomment-5770760074

   Fixed on `main` by #64105, so closing this.
   
   That PR removed the `GIT_ASKPASS` mechanism this issue reported on and 
replaced it with a host-scoped credential helper that is written and closed 
before git runs, which is exactly the constraint the report was about. The 
failing exec path no longer exists, so `cannot exec '/tmp/tmpXXXX.sh': Text 
file busy` can no longer occur for token or GitHub App authentication. I ran 
the provider hook tests against `main` in `apache/airflow:3.2.2-python3.10` 
(git 2.39.5) and all 55 pass, including the ones that invoke real `git 
ls-remote` calls through the new helper.
   
   Two notes for anyone who lands here from a search:
   
   * The fix is not released yet. `apache-airflow-providers-git` 0.5.0, 
currently the newest on PyPI, still has the bug, so on Linux a workaround is 
needed until the next provider release. #64105 also requires git 2.31 or newer 
on the Dag processor and workers, and it resets any deployment-wide 
`credential.helper` for the repository host.
   * The same open-file-then-exec pattern is still present in 
`_passphrase_askpass_env`, the `SSH_ASKPASS` helper used to unlock a 
passphrase-protected private key. That is not what this issue reported, and it 
is fixed separately by #73427.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to