Eason09053360 commented on code in PR #72958:
URL: https://github.com/apache/airflow/pull/72958#discussion_r4072317828
##########
airflow-core/tests/unit/cli/commands/test_variable_command.py:
##########
@@ -591,7 +608,7 @@ def test_variables_import_action_on_existing(self,
create_variable_file, simple_
# Test fail action - should fail when key1 already exists
Variable.set("key1", "original_value")
- with pytest.raises(SystemExit, match="already exists"):
+ with pytest.raises(SystemExit, match="already exist"):
Review Comment:
Thanks for the patch!
Just one nit:
`pytest.raises(match=...)` is `re.search`, so this still matches the old
`already exists.` — with `variable_command.py` reverted, this assertion passes
and only the new test fails.
```suggestion
with pytest.raises(SystemExit, match=r"already exist\."):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
