aaron-y-chen commented on code in PR #73509: URL: https://github.com/apache/airflow/pull/73509#discussion_r4075450918
########## providers/amazon/src/airflow/providers/amazon/aws/queues/kinesis.py: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING + +from airflow.providers.amazon.aws.triggers.kinesis import KinesisTrigger +from airflow.providers.common.compat.sdk import AirflowOptionalProviderFeatureException + +try: + from airflow.providers.common.messaging.providers.base_provider import BaseMessageQueueProvider +except ImportError: + raise AirflowOptionalProviderFeatureException( + "This feature requires the 'common.messaging' provider to be installed in version >= 2.0.0." + ) + +if TYPE_CHECKING: + from airflow.triggers.base import BaseEventTrigger + + +class KinesisMessageQueueProvider(BaseMessageQueueProvider): + """ + Configuration for Amazon Kinesis Data Streams integration with common-messaging. + + [START kinesis_message_queue_provider_description] Review Comment: After checking, I think you're right. This would cause a rendering issue in the official docs. For example: https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/_api/airflow/providers/amazon/aws/queues/sqs/index.html#module-contents I'll fix my part in this PR. I also think we should have a follow-up PR to clean up similar mistakes across the repo, as I found six files with the same issue. I'll take care of that later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
