bbovenzi commented on code in PR #73554:
URL: https://github.com/apache/airflow/pull/73554#discussion_r4085419638
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx:
##########
@@ -66,16 +66,19 @@ export const Logs = () => {
},
);
+ const defaultTryNumber =
+ taskInstance?.state === "up_for_retry" ? taskInstance.try_number - 1 :
taskInstance?.try_number;
Review Comment:
`try_number - 1` is giving me flashbacks to Airflow 2. I think ideally the
UI doesn't try to alter the try number. The empty state "no logs yet" message
in the screenshots makes sense to me.
We still may need to play with the auto-moving the try number selection on
refresh logic though. Right now, we try to automatically navigate to the latest
try as a task re-runs. But maybe we do need some `latest_try_number && state
!== null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
