nickstenning commented on code in PR #73244:
URL: https://github.com/apache/airflow/pull/73244#discussion_r4091936133
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2097,13 +2097,19 @@ workers:
max_failed_heartbeats:
description: |
The maximum number of consecutive failed heartbeats before terminating
the task instance process.
+
+ Unlike other calls to the execution API, heartbeats are not retried.
This setting and
+ ``min_heartbeat_interval`` together determine how long a worker
tolerates an unreachable API server
+ before killing running tasks.
version_added: 3.0.0
type: integer
example: ~
- default: "3"
+ default: "20"
Review Comment:
Ok, I've updated the PR description, the newsfragment and the defaulted
value to what I think are probably the best values we can use. In a "fast
failure" (e.g. failed DNS lookup) case this will now tolerate ~150s of API
server unavailability, and a "slow failure" (e.g. blackholed requests) it'll be
more like ~300s, which matches the scheduler's zombie timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
