namanjain24-sudo commented on PR #73535:
URL: https://github.com/apache/airflow/pull/73535#issuecomment-5811977787

   Correction to my note above: I re-checked the `uv.lock` hunk more carefully 
by actually merging this commit onto current main locally. The `1.0.1 -> 1.0.0` 
line is an artifact of diffing against a stale merge-base — a real merge 
produces zero diff against main's `uv.lock` (main is already at `1.0.0`, 
matching this PR's result). So that's not an issue, ignore that part of my 
earlier comment.
   
   The main point stands though, and I checked it more directly this time: 
cherry-picking this commit onto current main shows the new test 
(`test_async_start_from_trigger_with_templated_target_time`) landing right next 
to the pre-existing one added by #72659 
(`test_async_start_from_trigger_skips_templated_target_time`), covering the 
same scenario. Worth a rebase to see that side by side.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to