Miretpl commented on code in PR #72209:
URL: https://github.com/apache/airflow/pull/72209#discussion_r4098590223
##########
chart/templates/NOTES.txt:
##########
@@ -51,9 +51,12 @@ Flower Dashboard: kubectl port-forward svc/{{ include
"airflow.fullname" .
{{- end }}
{{- if .Values.createUserJob.enabled }}
-Default user (Airflow UI) Login credentials:
+User created by the create-user job (Airflow UI):
username: {{ .Values.createUserJob.defaultUser.username }}
- password: {{ .Values.createUserJob.defaultUser.password }}
+{{- else }}
+No Airflow UI user has been created. Create one with:
+ kubectl exec -it deploy/{{ include "airflow.fullname" . }}-api-server
--namespace {{ .Release.Namespace }} -- \
+ airflow users create -r Admin -u <username> -e <email> -f <first> -l
<last> -p <password>
Review Comment:
> This branch renders only when createUserJob.enabled is false, which after
this change is every default install. That's exactly the case where the
operator has no UI login and no indication they need to make one — deleting it
means a fresh install finishes with a working Airflow that nobody can sign in
to and no hint as to why.
>
> NOTES also renders for every install, not only production ones, so the
noise argument cuts differently here than it does in the production guide.
This is obvious when you know how e.g. Helm works and what is proposed in
this PR.
> If the airflow users create invocation appearing in NOTES was the concern,
that covers it.
It was not, which I pointed out in the comment. The concern is about
logging, which, in production, might be treated as noise (I would assume that
the majority of production environments will not have only one Airflow user
generated by the Helm Chart). Despite that, the current version is ok with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
