aaron-y-chen commented on code in PR #72555:
URL: https://github.com/apache/airflow/pull/72555#discussion_r4109423037


##########
chart/tests/helm_tests/security/test_kerberos.py:
##########
@@ -36,6 +36,19 @@ def test_kerberos_not_mentioned_in_render_if_disabled(self):
         k8s_objects_to_consider_str = json.dumps(k8s_objects_to_consider)
         assert k8s_objects_to_consider_str.count("kerberos") == 1
 
+    @pytest.mark.parametrize("init_values", [{"enabled": True}, {"enabled": 
False}, {}])
+    @pytest.mark.parametrize(
+        ("worker_type", "worker_set"),
+        [("celery", False), ("kubernetes", False), ("celery", True)],
+    )
+    def test_removed_kerberos_init_container_settings(self, init_values, 
worker_type, worker_set):
+        worker_values = {"kerberosInitContainer": init_values}
+        if worker_set:
+            worker_values = {"enableDefault": False, "sets": [{"name": "test", 
**worker_values}]}
+
+        with pytest.raises(HelmFailedError, match=r"kerberosInitContainer': 
'not' failed"):
+            render_chart(values={"workers": {worker_type: worker_values}})

Review Comment:
   Done, it's clearer now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to