developer-rpai commented on PR #73748: URL: https://github.com/apache/airflow/pull/73748#issuecomment-5864221732
@ColtenOuO all three inline threads are addressed in b331d86, and you were right about the tests -- there were none, now there are four: - `test_naive_datetime_serde_roundtrip`: end-to-end naive round-trip through the top-level serde - `test_naive_datetime_v3_roundtrip_independent_of_os_timezone`: serializes once, then deserializes under `TZ=UTC`, `America/New_York`, and `Asia/Kolkata` -- the exact #72635 writer/reader mismatch scenario - `test_naive_datetime_v3_interprets_epoch_in_default_timezone`: a v3 tz-less epoch resolves to the configured default-timezone wall time - `test_naive_datetime_v2_keeps_legacy_os_timezone_read`: a v2 tz-less payload keeps the legacy reader-OS-local read, so rolling upgrades do not shift in-flight data One thing I noticed while in there: v1 tz-less payloads raise inside the pre-existing tz-resolution block (`parse_timezone(None)`) before ever reaching the naive branch. That is untouched pre-existing behavior, not something this PR changes -- flagging in case it deserves its own look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
