ashb commented on code in PR #73836:
URL: https://github.com/apache/airflow/pull/73836#discussion_r4126725624


##########
scripts/ci/docker-compose/backend-postgres.yml:
##########
@@ -44,4 +47,7 @@ services:
     restart: "on-failure"
 volumes:
   postgres-data-volume:
-    name: "postgres${POSTGRES_VERSION}-db-volume"
+    labels:
+      org.apache.airflow.breeze: "true"
+      org.apache.airflow.breeze.worktree: "${BREEZE_WORKTREE_PATH:-}"
+    name: "${COMPOSE_PROJECT_NAME}-postgres${POSTGRES_VERSION}-db-volume"

Review Comment:
   Soooooo, it turns out there is basically no point in migrating, cos the 
volumes have been empty since November 2025 
https://github.com/apache/airflow/commit/9607baef89bc9bf50c2805edb19fff171a1e37e7
   
   I messed up the diff:
   
   ```
         - postgres-data-volume:/var/lib/postgresql/{$POSTGRES_VERSION}/docker
   ```
   Note, that is `{$` so it evaluates to `/var/lib/postgresql/{14}/docker` etc. 
Which means it creates a directory that nothing writes to.
   
   So since this has been broken for 10 months, I'll make the breeze code 
easier and just not deal with the empty volumes rather than have to always 
carry the migration code. (He says, already haven written it, and continually 
wondering why the migration was copying nothing)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to