MohammadHijjawi97 commented on code in PR #73864:
URL: https://github.com/apache/airflow/pull/73864#discussion_r4127251847
##########
providers/jenkins/tests/unit/jenkins/operators/test_jenkins_job_trigger.py:
##########
@@ -339,3 +339,26 @@ def test_build_job_request_settings(self):
assert mock_request.method == "POST"
assert mock_request.url == "http://apache.org";
+
+ @pytest.mark.parametrize(
+ ("parameters", "expected"),
+ [
+ pytest.param(
+ '{"dry_run": true, "notify": false}', {"dry_run": True,
"notify": False}, id="json booleans"
+ ),
+ pytest.param("{'dry_run': True}", {"dry_run": True}, id="python
literals"),
+ ],
Review Comment:
Added the `json null` case in 3dd413b. `json.loads` returns `{"dry_run":
True, "optional": None}` for it, and the original `ast.literal_eval` path
raises `ValueError` on it.
---
Drafted-by: Claude Code (Claude Opus 5.5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
