abhishekmauryaKsolves commented on PR #73647: URL: https://github.com/apache/airflow/pull/73647#issuecomment-5883539412
Thanks for the review. Addressed all three points in 4fec830273: 1. key_file/pkey guard — Fixed. key_file is now `None if self.pkey else self.key_file` on the worker hook, so the guard in SSHHook doesn't trip when a `private_key` extra has already resolved to `pkey` on the parent. 2. Mock spec — Updated to `MagicMock(spec=Connection)` in test_build_worker_hook_inherits_parent_overrides. 3. Weak assertions — Simplified test_store_and_retrieve_directory_concurrently_use_parent_overrides to a wiring test that just asserts `_build_worker_hook` is called once per worker; value-level checks are already covered by test_build_worker_hook_inherits_parent_overrides. All 127 tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
