kgskgs commented on code in PR #73806:
URL: https://github.com/apache/airflow/pull/73806#discussion_r4130745151
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1905,6 +1917,7 @@ def _monitor_subprocess(self):
self._send_heartbeat_if_needed()
Review Comment:
if the heartbeat fails (e.g. you have manually changed the state of the dag
from running to failed, and you get `ServerResponseError` conflict here) in the
this method, the task will be killed immediately with
`self.kill(signal.SIGTERM, force=True)` with a 5 sec grace period without
respecting the configured timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
