Leondon9 commented on PR #73719: URL: https://github.com/apache/airflow/pull/73719#issuecomment-5892200629
> I have left some comments. Thanks for the review, @SameerMesiah97 ! All comments addressed. Two done slightly differently: - except: narrowed to (BotoCoreError, ClientError) (not just ClientError) so a connection error during the cancel can't re-mask the real reason. - terminal failure vs. timeout: the trigger now tags the event with a failure_type (via WaiterTerminalFailure/WaiterMaxAttemptsError), and the operator raises an outcome-specific message and cancels only on a timeout — a terminal failure is already done, so it's no longer cancelled. Left the error case as don't cancel; happy to change if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
