shivaam commented on code in PR #68961:
URL: https://github.com/apache/airflow/pull/68961#discussion_r4140053047


##########
airflow-core/src/airflow/api_fastapi/core_api/openapi/_private_ui.yaml:
##########
@@ -3643,6 +3643,9 @@ components:
           description: Interval in seconds between the reference time and the 
deadline.
             Null for a dynamic interval (e.g. a VariableInterval) whose value 
is only
             resolved at scheduler evaluation time.
+        fire_on_failure:

Review Comment:
   `fire_on_failure` lets a deadline alert fire immediately when its DagRun 
fails, even if the deadline hasn’t expired. It defaults to `False` to preserve 
existing behavior.
   
   This particular YAML change exposes that policy in the API response for a 
future UI addition—for example, showing “Also alert on DagRun failure” 
alongside the deadline details, so users understand why an alert fired before 
its configured deadline.
   
   The current UI doesn’t consume this field yet, so we can omit it from the 
private UI response for now and add it alongside that UI change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to